On 02/01/2012 03:51 PM, Paul B Mahol wrote:

> On 2/1/12, Justin Ruggles <[email protected]> wrote:
>> On 02/01/2012 03:40 PM, Paul B Mahol wrote:
>>
>>> On 2/1/12, Justin Ruggles <[email protected]> wrote:
>>>> On 02/01/2012 03:23 PM, Paul B Mahol wrote:
>>>>
>>>>>
>>>>> Signed-off-by: Paul B Mahol <[email protected]>
>>>>> ---
>>>>>  libavcodec/frwu.c |   20 +++++++++++---------
>>>>>  1 files changed, 11 insertions(+), 9 deletions(-)
>>>>>
>>>>> diff --git a/libavcodec/frwu.c b/libavcodec/frwu.c
>>>>> index eba0530..9ef29cd 100644
>>>>> --- a/libavcodec/frwu.c
>>>>> +++ b/libavcodec/frwu.c
>>>>> @@ -28,7 +28,7 @@ static av_cold int decode_init(AVCodecContext *avctx)
>>>>>  {
>>>>>      if (avctx->width & 1) {
>>>>>          av_log(avctx, AV_LOG_ERROR, "FRWU needs even width\n");
>>>>> -        return -1;
>>>>> +        return AVERROR_INVALIDDATA;
>>>>
>>>>
>>>> This should be AVERROR(EINVAL).
>>>
>>> Isn't that for encoders when user specify invalid value?
>>
>>
>> The user can specify an invalid value for decoders too.
> 
> This is inconsistent with v410dec.c


Then v410dec.c needs to be fixed too.

-Justin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to