Hi, (old patch review.)
On Thu, Jan 19, 2012 at 7:15 AM, Diego Biurrun <[email protected]> wrote: > Also prettyprint some comments in Assembly code. > --- > libswscale/bfin/internal_bfin.S | 12 +++--- > libswscale/bfin/swscale_bfin.c | 48 +++++++++++--------- > libswscale/bfin/yuv2rgb_bfin.c | 91 > ++++++++++++++++++++------------------- > 3 files changed, 78 insertions(+), 73 deletions(-) [..] Most of this looks good, the only thing I'm not sure of is this: > diff --git a/libswscale/bfin/swscale_bfin.c b/libswscale/bfin/swscale_bfin.c [..] > #if defined (__FDPIC__) && CONFIG_SRAM > -#define L1CODE __attribute__ ((l1_text)) > +#define L1CODE __attribute__((l1_text)) > #else > #define L1CODE > #endif [..] > diff --git a/libswscale/bfin/yuv2rgb_bfin.c b/libswscale/bfin/yuv2rgb_bfin.c [..] > #if defined(__FDPIC__) && CONFIG_SRAM > -#define L1CODE __attribute__ ((l1_text)) > +#define L1CODE __attribute__((l1_text)) > #else > #define L1CODE > #endif Because I simply don't know if the space is required or not. I'm pretty sure it's not, so then it's fine to remove it, but just want to make sure (Mans?). Rest of the patch is OK. Ronald _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
