On Wed, Feb 01, 2012 at 09:31:43PM -0800, Ronald S. Bultje wrote: > On Wed, Jan 18, 2012 at 10:25 AM, Diego Biurrun <[email protected]> wrote: > [..] > > @@ -41,106 +42,104 @@ altivec_packIntArrayToCharArray(int *val, uint8_t* > > dest, int dstW) > [..] > > + for (i = 0; (i < dstW) && > > Remove brackets around "i < dstW". > > > + for (; i < (dstW - 15); i += 16) { > > Same around "dstW - 15". > > > + for (i = 0; i < (dstW - 15); i += 16) { > > Same. > > > + for (i = 0; i < (dstW - 7); i += 8) { > > Likewise.
I would prefer to leave parentheses removal out of a K&R patch. Also, I'm sure there are many more parentheses to drop if we start looking for them in these files. > > - vector signed short src_vA = // vec_unpackh sign-extends... > > - (vector signed short)(vec_mergeh((vector unsigned > > char)vzero, src_vF)); > > - vector signed short src_vB = // vec_unpackh sign-extends... > > - (vector signed short)(vec_mergel((vector unsigned > > char)vzero, src_vF)); > > + vector signed short src_vA = // vec_unpackh sign-extends... > > + (vector signed > > short)(vec_mergeh((vector unsigned char)vzero, src_vF)); > > + vector signed short src_vB = // vec_unpackh sign-extends... > > + (vector signed > > short)(vec_mergel((vector unsigned char)vzero, src_vF)); > > Hm, can you elaborate on this? Look at the context, this is at the correct indentation level. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
