On Sat, Feb 04, 2012 at 04:57:03PM +0000, Ronald S. Bultje wrote: > Also slightly move around code not allocate a new frame if we won't > decode it. This prevents us from putting undecoded frames in frame > pointers, which (in mt decoding) other threads will use and wait on > as references, causing a deadlock (if we skipped decoding) or a crash > (if we didn't initialized next_framep[] at all). > > Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind > --- > libavcodec/vp8.c | 33 +++++++++++++++++++-------------- > 1 files changed, 19 insertions(+), 14 deletions(-)
> From 054ed04e2752a982e50fad0b1a637d4ebd0aab1f Mon Sep 17 00:00:00 2001 > From: "Ronald S. Bultje" <[email protected]> > Date: Tue, 31 Jan 2012 15:17:59 -0800 > Subject: [PATCH] vp8: always update next_framep[] before returning from > decode_frame(). > > Also slightly move around code not allocate a new frame if we won't > decode it. This prevents us from putting undecoded frames in frame > pointers, which (in mt decoding) other threads will use and wait on > as references, causing a deadlock (if we skipped decoding) or a crash > (if we didn't initialized next_framep[] at all). > > Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind > --- > libavcodec/vp8.c | 33 +++++++++++++++++++-------------- > 1 files changed, 19 insertions(+), 14 deletions(-) LGTM (reviewed at FOSDEM though) _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
