Hi, On Sat, Feb 4, 2012 at 11:12 PM, Jason Garrett-Glaser <[email protected]> wrote: > On Sat, Feb 4, 2012 at 8:46 AM, Ronald S. Bultje <[email protected]> wrote: >> With patch this time (silly fosdem for blocking smtp ports :-( ). >> >> On Sat, Feb 4, 2012 at 4:45 PM, Ronald S. Bultje <[email protected]> wrote: >>> Functions using INIT_MMX may still access XMM registers through direct >>> means (xmm0-15). Therefore, they still need to be marked for clobber >>> so they can be properly saved/restored. > > Patch rejected per discussion on IRC; if your function needs that many > xmm registers, it should probably be marked with INIT_XMM, not > INIT_MMX. This change breaks a lot of functions in x264, and I'd > rather keep lav synced...
Of course, I don't want local (i.e. Libav) modifications to x86inc.asm wrt upstream (x264's). Is Gramner's suggestion to make WIN64_SPILL/RESTORE_XMM public OK with you? I think that's the cleanest solution for this kind of scenario. Ronald _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
