On Mon, Feb 06, 2012 at 06:05:42PM +0530, Aneesh Dogra wrote: > On 6 Feb 2012 15:06, "Diego Biurrun" <[email protected]> wrote: > > On Mon, Feb 06, 2012 at 12:24:58PM +0530, Aneesh Dogra wrote: > > > --- > > > libavcodec/dnxhddec.c | 3 --- > > > libavcodec/dnxhdenc.c | 1 - > > > libavcodec/dsputil.h | 2 -- > > > libavcodec/gifdec.c | 1 - > > > libavcodec/h263.c | 4 ---- > > > libavcodec/h263dec.c | 1 - > > > libavcodec/ituh263dec.c | 4 ---- > > > libavcodec/ituh263enc.c | 4 ---- > > > libavcodec/mjpegenc.c | 1 - > > > libavcodec/mpeg12.c | 5 ----- > > > libavcodec/mpegvideo.c | 10 ---------- > > > libavcodec/mpegvideo_enc.c | 8 -------- > > > libavcodec/msmpeg4.c | 1 - > > > libavcodec/pngdec.c | 2 -- > > > libavcodec/pngenc.c | 2 -- > > > libavcodec/rv10.c | 2 -- > > > libavcodec/rv34.c | 2 -- > > > libavcodec/tta.c | 2 +- > > > libavformat/isom.c | 2 -- > > > libavformat/mov.c | 1 - > > > libavformat/mxfdec.c | 2 -- > > > libavformat/mxfenc.c | 2 -- > > > libavformat/r3d.c | 2 -- > > > libavformat/rtp.c | 2 -- > > > libavformat/rtpdec.c | 2 -- > > > libavformat/rtpenc.c | 2 -- > > > libavformat/rtsp.c | 2 -- > > > libpostproc/postprocess.c | 1 - > > > 28 files changed, 1 insertions(+), 72 deletions(-) > > > > git-grep shows me instances you have missed, try > > > > git grep 'define DEBUG' > > The other debugs you see is actually being used in the code. I mean there > are some #ifdef DEBUG blocks if you scroll down the file. The commented > macros i deleted were actually not even used in the code below.
Even those are rather pointless since commenting in the lines will still mark the files as modified in git. Adding a DEBUG #define is trivial, so it's not really something that you need to have lying around in a commented-out state just in case ... > [... many unnecessarily quoted lines ...] Please snip your quotes. This mailing list is read by a lot of people and making them all scroll through your quoted text wastes a lot of time. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
