Justin Ruggles <[email protected]> wrote: >On 02/08/2012 04:14 PM, Paul B Mahol wrote: > >> Signed-off-by: Paul B Mahol <[email protected]> >> --- >> libavformat/wv.c | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/libavformat/wv.c b/libavformat/wv.c >> index c39cc68..a23d8bb 100644 >> --- a/libavformat/wv.c >> +++ b/libavformat/wv.c >> @@ -316,6 +316,7 @@ static int wv_read_packet(AVFormatContext *s, >> pkt->stream_index = 0; >> wc->block_parsed = 1; >> pkt->pts = wc->soff; >> + pkt->duration = AV_RN32(wc->extra); >> av_add_index_entry(s->streams[0], pos, pkt->pts, 0, 0, >AVINDEX_KEYFRAME); >> return 0; >> } > > >The WavPack documentation defines that as unsigned, and duration is >signed, so we probably should check for overflow. > >-Justin >_______________________________________________ >libav-devel mailing list >[email protected] >https://lists.libav.org/mailman/listinfo/libav-devel
Why is it signed? Negative duration doesn't make much sense. -- Måns Rullgård [email protected] _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
