On Wed, 8 Feb 2012 20:59:40 +0200, Andrey Utkin <[email protected]> wrote: > UP. > Please somebody look at this patch, comments are appreciated. >
I'm basically ok with allowing the caller to override the duration, but we should make the API semantics a bit clearer first. If the user set the duration when encoding, do we want to a) assume he knows what he's doing and write this duration always OR b) only use this duration if the file is not seekable. If we pick a), then your patch also needs to test for file seekability, since input might be shorter than the supplied -t value, so we end up writing wrong duration even for seekable files. (though we might want to change the semantics of -t to duplicate frames /pad with silence to get requested duration). -- Anton Khirnov _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
