On Sat, 11 Feb 2012 14:34:00 -0800, "Ronald S. Bultje" <[email protected]> wrote: > Hi, > > On Sat, Feb 11, 2012 at 12:25 PM, Anton Khirnov <[email protected]> wrote: > > --- > > libavcodec/Makefile | 8 +- > > libavcodec/asv1.c | 577 > > +------------------------------------------------- > > libavcodec/asv1.h | 63 ++++++ > > libavcodec/asv1dec.c | 328 ++++++++++++++++++++++++++++ > > libavcodec/asv1enc.c | 279 ++++++++++++++++++++++++ > > 5 files changed, 682 insertions(+), 573 deletions(-) > > create mode 100644 libavcodec/asv1.h > > create mode 100644 libavcodec/asv1dec.c > > create mode 100644 libavcodec/asv1enc.c > > Probably OK... > > Some comments though: > > > +typedef struct ASV1Context { > [..] > > + AVFrame picture; > > I assume the picture is decoder-only, since encoder uses coded_frame? >
coded_frame is just a pointer, it points to this picture. > > + PutBitContext pb; > > + GetBitContext gb; > > Silly, split enc/dec context please. > > > + int mb_width; > > + int mb_height; > > + int mb_width2; > > + int mb_height2; > > Doxy would help here. If i understood what those were for.... -- Anton Khirnov _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
