Hi,
On Mon, Feb 13, 2012 at 5:02 PM, Janne Grunau <[email protected]> wrote:
> On 2012-02-13 16:35:50 -0800, Ronald S. Bultje wrote:
>> From: "Ronald S. Bultje" <[email protected]>
>>
>> Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
>> CC: [email protected]
>> ---
>> libavcodec/golomb.h | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/libavcodec/golomb.h b/libavcodec/golomb.h
>> index 503aa14..c176463 100644
>> --- a/libavcodec/golomb.h
>> +++ b/libavcodec/golomb.h
>> @@ -123,7 +123,7 @@ static inline int svq3_get_ue_golomb(GetBitContext *gb){
>> }else{
>> int ret = 1;
>>
>> - while (1) {
>> + do {
>
> while (ret) {
>
>> buf >>= 32 - 8;
>> LAST_SKIP_BITS(re, gb,
>> FFMIN(ff_interleaved_golomb_vlc_len[buf], 8));
>>
>> @@ -135,7 +135,7 @@ static inline int svq3_get_ue_golomb(GetBitContext *gb){
>> ret = (ret << 4) | ff_interleaved_dirac_golomb_vlc_code[buf];
>> UPDATE_CACHE(re, gb);
>> buf = GET_CACHE(re, gb);
>> - }
>> + } while (ret);
>
> indentation off and unnecessary
do{}while() prevents the check on first loop iteration.
Ronald
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
