On Thu, Feb 16, 2012 at 12:18:15PM +0100, Kostya Shishkov wrote:
> On Thu, Feb 16, 2012 at 11:51:54AM +0100, Diego Biurrun wrote:
> > On Wed, Feb 15, 2012 at 07:16:34AM +0100, Kostya Shishkov wrote:
> > > 
> > > Author:    Kostya Shishkov <[email protected]>
> > > Committer: Kostya Shishkov <[email protected]>
> > > Date:      Thu Feb  2 20:54:53 2012 +0100
> > > 
> > > prores encoder
> > 
> > This does not compile standalone.  Since we have a checklist in the
> > documentation for this, I hereby refer you to it:
> > 
> > http://www.libav.org/developer.html#New-codecs-or-formats-checklist
> > 
> > Since Ronald will come complaining to me if I reply tersely like this,
> > I draw your attention to point 12:
> > 
> > 12. Did you make sure it compiles standalone, i.e. with configure
> >     --disable-everything --enable-decoder=foo (or --enable-demuxer
> >     or whatever your component is)?
> 
> My bad, here's the fix.
> 
> --- a/libavcodec/x86/Makefile
> +++ b/libavcodec/x86/Makefile
> @@ -46,7 +46,9 @@ MMX-OBJS-$(CONFIG_LPC)                 += x86/lpc_mmx.o
>  YASM-OBJS-$(CONFIG_PNG_DECODER)        += x86/pngdsp.o
>  MMX-OBJS-$(CONFIG_PNG_DECODER)         += x86/pngdsp-init.o
>  YASM-OBJS-$(CONFIG_PRORES_DECODER)     += x86/proresdsp.o
> +YASM-OBJS-$(CONFIG_PRORES_ENCODER)     += x86/proresdsp.o
>  MMX-OBJS-$(CONFIG_PRORES_DECODER)      += x86/proresdsp-init.o
> +MMX-OBJS-$(CONFIG_PRORES_ENCODER)      += x86/proresdsp-init.o
>  MMX-OBJS-$(CONFIG_DWT)                 += x86/snowdsp_mmx.o

I don't think it's the correct fix.  I'm under the impression that
decoder and encoder are not properly separated.  Note that both
fail standalone compilation - does this fix both?

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to