On Fri, Feb 17, 2012 at 3:23 PM, Martin Storsjö <[email protected]> wrote: > On Fri, 17 Feb 2012, Ronald S. Bultje wrote: > >> On Fri, Feb 17, 2012 at 3:10 PM, Martin Storsjö <[email protected]> wrote: >>> >>> On Fri, 17 Feb 2012, Ronald S. Bultje wrote: >>> >>>> From: "Ronald S. Bultje" <[email protected]> >>>> >>>> --- >>>> libavcodec/mpc7.c | 2 +- >>>> 1 files changed, 1 insertions(+), 1 deletions(-) >>>> >>>> diff --git a/libavcodec/mpc7.c b/libavcodec/mpc7.c >>>> index 0739bf2..2e8271a 100644 >>>> --- a/libavcodec/mpc7.c >>>> +++ b/libavcodec/mpc7.c >>>> @@ -298,7 +298,7 @@ static int mpc7_decode_frame(AVCodecContext * avctx, >>>> void *data, >>>> bits_used = get_bits_count(&gb); >>>> bits_avail = buf_size * 8; >>>> if (!last_frame && ((bits_avail < bits_used) || (bits_used + 32 <= >>>> bits_avail))) { >>>> - av_log(NULL,0, "Error decoding frame: used %i of %i bits\n", >>>> bits_used, bits_avail); >>>> + av_log(avctx, AV_LOG_ERROR, "Error decoding frame: used %i of >>>> %i >>>> bits\n", bits_used, bits_avail); >>>> return -1; >>>> } >>>> if(c->frames_to_skip){ >>>> -- >>>> 1.7.7.4 >>> >>> >>> >>> Ok. >>> >>> Perhaps the context should be mentioned in the message, too, it looks a >>> bit >>> mismatched right now... >> >> >> Isn't that what the context is for? >> >> [mpc7 @ 0x101809800] Error decoding frame: used 1305 of 526176 bits >> ^^^^ > > > Sorry, I was a bit too terse and ambiguous - I meant mentioning it in the > commit message :-) I meant it looks a bit weird when the message says "set > level" when you actually set both context+level. >
LGTM with updated commit message _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
