On Sat, Feb 18, 2012 at 02:49:01AM +0530, Aneesh Dogra wrote:
>
> --- a/libavformat/gif.c
> +++ b/libavformat/gif.c
> @@ -128,14 +128,14 @@ static int gif_image_write_header(AVIOContext *pb,
> avio_w8(pb, (v >> 16) & 0xff);
> - avio_w8(pb, (v >> 8) & 0xff);
> + avio_w8(pb, (v >> 8) & 0xff);
Right-align the 8 for better readability.
> @@ -346,7 +346,8 @@ static int gif_write_trailer(AVFormatContext *s)
> #define OFFSET(x) offsetof(GIFContext, x)
> #define ENC AV_OPT_FLAG_ENCODING_PARAM
> static const AVOption options[] = {
> - { "loop", "Number of times to loop the output.", OFFSET(loop),
> AV_OPT_TYPE_INT, {0}, 0, 65535, ENC },
> + { "loop", "Number of times to loop the output.", OFFSET(loop),
> + AV_OPT_TYPE_INT, {0}, 0, 65535, ENC },
spaces inside {}
There are a bunch of places where you missed alignment opportunities;
I suggest you go over the file one more time.
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
