On Sat, Feb 18, 2012 at 02:27:28AM +0200, Martin Storsjö wrote: > On Fri, 17 Feb 2012, Ronald S. Bultje wrote: > > >From: "Ronald S. Bultje" <[email protected]> > > > >The parser uses VLC tables initialized in vc1_common_init(), therefore > >we should call this function on parser init also. > > > >Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind > >CC: [email protected] > >--- > >libavcodec/vc1.h | 1 + > >libavcodec/vc1_parser.c | 2 +- > >libavcodec/vc1dec.c | 2 +- > >3 files changed, 3 insertions(+), 2 deletions(-) > > > >diff --git a/libavcodec/vc1.h b/libavcodec/vc1.h > >index f895aad..4b601fe 100644 > >--- a/libavcodec/vc1.h > >+++ b/libavcodec/vc1.h > >@@ -447,5 +447,6 @@ int ff_vc1_decode_entry_point(AVCodecContext *avctx, > >VC1Context *v, GetBitContex > > > >int ff_vc1_parse_frame_header (VC1Context *v, GetBitContext *gb); > >int ff_vc1_parse_frame_header_adv(VC1Context *v, GetBitContext *gb); > >+int vc1_init_common(VC1Context *v); > > Please add the ff_ prefix when you make it nonstatic. > > (Other than that, I think the patch looks good with that changed, > but I'd like Kostya's opinion, too.)
LGTM too _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
