On 02/19/2012 09:52 AM, Anton Khirnov wrote:

> 
> On Sun, 19 Feb 2012 05:20:01 +0000, Paul B Mahol <[email protected]> wrote:
>>
>> Signed-off-by: Paul B Mahol <[email protected]>
>> ---
>>  libavcodec/pnmdec.c |    5 -----
>>  1 files changed, 0 insertions(+), 5 deletions(-)
>>
>> diff --git a/libavcodec/pnmdec.c b/libavcodec/pnmdec.c
>> index e0e9f66..c5d236f 100644
>> --- a/libavcodec/pnmdec.c
>> +++ b/libavcodec/pnmdec.c
>> @@ -197,7 +197,6 @@ AVCodec ff_pgm_decoder = {
>>      .close          = ff_pnm_end,
>>      .decode         = pnm_decode_frame,
>>      .capabilities   = CODEC_CAP_DR1,
>> -    .pix_fmts  = (const enum PixelFormat[]){PIX_FMT_GRAY8, 
>> PIX_FMT_GRAY16BE, PIX_FMT_NONE},
>>      .long_name = NULL_IF_CONFIG_SMALL("PGM (Portable GrayMap) image"),
>>  };
>>  #endif
>> @@ -212,7 +211,6 @@ AVCodec ff_pgmyuv_decoder = {
>>      .close          = ff_pnm_end,
>>      .decode         = pnm_decode_frame,
>>      .capabilities   = CODEC_CAP_DR1,
>> -    .pix_fmts  = (const enum PixelFormat[]){PIX_FMT_YUV420P, PIX_FMT_NONE},
>>      .long_name = NULL_IF_CONFIG_SMALL("PGMYUV (Portable GrayMap YUV) 
>> image"),
>>  };
>>  #endif
>> @@ -227,7 +225,6 @@ AVCodec ff_ppm_decoder = {
>>      .close          = ff_pnm_end,
>>      .decode         = pnm_decode_frame,
>>      .capabilities   = CODEC_CAP_DR1,
>> -    .pix_fmts  = (const enum PixelFormat[]){PIX_FMT_RGB24, PIX_FMT_RGB48BE, 
>> PIX_FMT_NONE},
>>      .long_name = NULL_IF_CONFIG_SMALL("PPM (Portable PixelMap) image"),
>>  };
>>  #endif
>> @@ -242,7 +239,6 @@ AVCodec ff_pbm_decoder = {
>>      .close          = ff_pnm_end,
>>      .decode         = pnm_decode_frame,
>>      .capabilities   = CODEC_CAP_DR1,
>> -    .pix_fmts  = (const enum PixelFormat[]){PIX_FMT_MONOWHITE, 
>> PIX_FMT_NONE},
>>      .long_name = NULL_IF_CONFIG_SMALL("PBM (Portable BitMap) image"),
>>  };
>>  #endif
>> @@ -257,7 +253,6 @@ AVCodec ff_pam_decoder = {
>>      .close          = ff_pnm_end,
>>      .decode         = pnm_decode_frame,
>>      .capabilities   = CODEC_CAP_DR1,
>> -    .pix_fmts  = (const enum PixelFormat[]){PIX_FMT_RGB24, PIX_FMT_RGB32, 
>> PIX_FMT_GRAY8, PIX_FMT_MONOWHITE, PIX_FMT_NONE},
>>      .long_name = NULL_IF_CONFIG_SMALL("PAM (Portable AnyMap) image"),
>>  };
>>  #endif
>> -- 
>> 1.7.7
>>
> 
> I'm not sure those should be removed.
> Maybe it'd be better to add a sanity check to avcodec_open2() using
> those pix_fmts.


How does having a pix_fmts list make sense at all for decoders?

-Justin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to