On Mon, Feb 20, 2012 at 03:54:43AM +0000, Paul B Mahol wrote: > > Signed-off-by: Paul B Mahol <[email protected]> > --- > libavformat/Makefile | 8 +- > libavformat/img2.c | 436 > +------------------------------------------------ > libavformat/img2.h | 35 ++++ > libavformat/img2dec.c | 324 ++++++++++++++++++++++++++++++++++++ > libavformat/img2enc.c | 152 +++++++++++++++++ > 5 files changed, 519 insertions(+), 436 deletions(-) > create mode 100644 libavformat/img2.h > create mode 100644 libavformat/img2dec.c > create mode 100644 libavformat/img2enc.c
Try "git-send-email -M". The patch looks mostly good at a glance, some comments below. > --- /dev/null > +++ b/libavformat/img2.h > @@ -0,0 +1,35 @@ > +/* > + * Image format This is not a very enlightening comment. > +#include "libavcodec/avcodec.h" > + > +#ifndef AVFORMAT_IMG2_H > +#define AVFORMAT_IMG2_H Move the #include below the inclusion guard. > +enum CodecID av_str2id(const IdStrMap *tags, const char *str); This is not a public function, so it should have an ff_ prefix. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
