On Tue, Feb 21, 2012 at 06:02:15PM +0000, Måns Rullgård wrote: > "Ronald S. Bultje" <[email protected]> writes: > > > > --- a/tests/lavfi-regression.sh > > +++ b/tests/lavfi-regression.sh > > @@ -40,13 +40,14 @@ do_lavfi "vflip_crop" > > "vflip,crop=iw-100:ih-100:100:100" > > do_lavfi "vflip_vflip" "vflip,vflip" > > > > do_lavfi_pixfmts(){ > > - test ${test%_[bl]e} = pixfmts_$1 || return 0 > > + test ${test%_[bl]e} = pixfmts_${4:-${1}} || return 0 > > I'd prefer giving ${4:-$1} a name rather than repeating it everywhere.
Same sentiment here - patch looks good to me otherwise. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
