Hi, On Fri, Feb 24, 2012 at 11:04 AM, Paul B Mahol <[email protected]> wrote: > On 2/24/12, Maans Rullgaard <[email protected]> wrote: >> Paul B Mahol <[email protected]> writes: >> >>> On 2/24/12, Maans Rullgaard <[email protected]> wrote: >>>> Paul B Mahol <[email protected]> writes: >>>> >>>>> On 2/24/12, Maans Rullgaard <[email protected]> wrote: >>>>>> Paul B Mahol <[email protected]> writes: >>>>>> >>>>>>> On 2/24/12, Maans Rullgaard <[email protected]> wrote: >>>>>>>> Paul B Mahol <[email protected]> writes: >>>>>>>> >>>>>>>>> Signed-off-by: Paul B Mahol <[email protected]> >>>>>>>>> --- >>>>>>>>> libavcodec/png.c | 3 --- >>>>>>>>> libavcodec/png.h | 6 +++--- >>>>>>>>> libavcodec/pngdec.c | 4 ++-- >>>>>>>>> libavcodec/pngenc.c | 2 +- >>>>>>>>> 4 files changed, 6 insertions(+), 9 deletions(-) >>>>>>>> >>>>>>>> Why? >>>>>>> >>>>>>> MNG-VLC demuxer/muxer >>>>>> >>>>>> That is not an answer. >>>>> >>>>> How should than one get such value from libavformat? >>>> >>>> Please explain what problem this change is supposed to solve. >>> >>> See line above your question. >> >> That explains neither the problem nor the proposed solution. Try again. > > Problem: Code duplication. > Solution: Move code to header so it can be used from libavformat.
Mans would like you to not duplicate the memory, i.e. don't #define it, rather make it a static const char *varname; declaration in the header, and then have a data file where that memory is actually existing. Ronald _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
