Anton Khirnov <[email protected]> writes: > On Mon, 27 Feb 2012 20:34:24 +0000, Måns Rullgård <[email protected]> wrote: >> Anton Khirnov <[email protected]> writes: >> >> > diff --git a/libavcodec/mpegvideo.h b/libavcodec/mpegvideo.h >> > index 4ec4190..3521a12 100644 >> > --- a/libavcodec/mpegvideo.h >> > +++ b/libavcodec/mpegvideo.h >> > @@ -691,6 +691,8 @@ typedef struct MpegEncContext { >> > void (*denoise_dct)(struct MpegEncContext *s, DCTELEM *block); >> > >> > int mpv_flags; ///< flags set by private options >> > + >> > + int rv10_id; ///< a version identifier used by the rv10 decoder >> > } MpegEncContext; >> >> Is there really no better place for this? > > rv10 uses MpegEncContext as its private data, so no, i don't see any. > I could "subclass" it, but that seemed an overkill for just one variable.
I bet that's the thought process behind most of the weird fields in that (and other) struct(s). -- Måns Rullgård [email protected] _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
