On Sun, Feb 19, 2012 at 04:32:01PM -0800, Ronald S. Bultje wrote: > On 64bit platforms with 32bit int, this means we won't have to sign- > extend the integer anymore. > --- > libavcodec/arm/vp8dsp_init_arm.c | 32 ++++---- > libavcodec/ppc/vp8dsp_altivec.c | 16 ++-- > libavcodec/vp8dsp.c | 44 +++++----- > libavcodec/vp8dsp.h | 38 +++++----- > libavcodec/x86/vp8dsp-init.c | 158 > +++++++++++++++++++------------------- > 5 files changed, 144 insertions(+), 144 deletions(-) > > diff --git a/libavcodec/arm/vp8dsp_init_arm.c > b/libavcodec/arm/vp8dsp_init_arm.c > index 5eea846..83f3634 100644 > --- a/libavcodec/arm/vp8dsp_init_arm.c > +++ b/libavcodec/arm/vp8dsp_init_arm.c > @@ -22,38 +22,38 @@ > void ff_vp8_luma_dc_wht_neon(DCTELEM block[4][4][16], DCTELEM dc[16]); > void ff_vp8_luma_dc_wht_dc_neon(DCTELEM block[4][4][16], DCTELEM dc[16]); > > -void ff_vp8_idct_add_neon(uint8_t *dst, DCTELEM block[16], int stride); > -void ff_vp8_idct_dc_add_neon(uint8_t *dst, DCTELEM block[16], int stride); > -void ff_vp8_idct_dc_add4y_neon(uint8_t *dst, DCTELEM block[4][16], int > stride); > -void ff_vp8_idct_dc_add4uv_neon(uint8_t *dst, DCTELEM block[4][16], int > stride); > +void ff_vp8_idct_add_neon(uint8_t *dst, DCTELEM block[16], ptrdiff_t stride); > +void ff_vp8_idct_dc_add_neon(uint8_t *dst, DCTELEM block[16], ptrdiff_t > stride); > +void ff_vp8_idct_dc_add4y_neon(uint8_t *dst, DCTELEM block[4][16], ptrdiff_t > stride); > +void ff_vp8_idct_dc_add4uv_neon(uint8_t *dst, DCTELEM block[4][16], > ptrdiff_t stride);
Those lines have grown too long, please break them. The same applies to declarations at the end of vp8dsp.h Otherwise LGTM _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
