Hi,

On Sat, Mar 3, 2012 at 12:25 PM, Ronald S. Bultje <[email protected]> wrote:
> On Sat, Mar 3, 2012 at 10:22 AM, Aneesh Dogra <[email protected]> wrote:
>> ---
>>  libavcodec/qpeg.c |   83 
>> +++++++++++++++++++++++++---------------------------
>>  1 files changed, 40 insertions(+), 43 deletions(-)
>
> Good stuff! Can you change it so it embeds the GetByteContext in the
> QpegContext, and then provide that as argument into the
> decode_inter/intra() functions? Otherwise the patch is OK.

Oh, and since the input buffer needs to be at least 0x86 bytes long,
you could add a check that if avpkt->size < 0x86, av_log(some error)
and then return AVERROR_INVALIDDATA, saves us returning corrupt data.

Ronald
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to