On Sat, Mar 17, 2012 at 07:31:44PM +0100, Vitor Sessak wrote:
> On 03/17/2012 08:54 AM, Kostya Shishkov wrote:
> >$subj
> >
> >ralfdata.h is attached separately because it's less interesting and it's more
> >than 600k in plain form (yet it's still smaller that
> >libavcodec/twinvq_data.h).
>
> Just two small things:
>
> >#define FILTERPARAM_ELEMENTS 643
> >#define BIAS_ELEMENTS 255
> >#define CODING_MODE_ELEMENTS 140
> >#define FILTER_COEFFS_ELEMENTS 43
> >#define SHORT_CODES_ELEMENTS 169
> >#define LONG_CODES_ELEMENTS 441
>
> Since those are not needed in ralfdata.h, I think they could be in ralf.c...
I just group defines with the data they relate to.
> >+typedef struct RALFContext {
> >+ AVFrame frame;
> >+
> >+ int version;
> >+ int max_frame_size;
> >+ VLCSet sets[3];
>
> >+ int *channel_data[2];
>
> Do channel_data need to be preserved between frames or can you just
> write directly to the output buffer?
Channel can have resolution of 17 bits (before combining), output is always 16
bits.
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
