Justin Ruggles <[email protected]> writes: > On 03/20/2012 04:37 PM, Måns Rullgård wrote: > >> Justin Ruggles <[email protected]> writes: >> >>> We do not need to keep setting it while flushing the encoder. >>> --- >>> libavcodec/libvorbis.c | 5 +++-- >>> 1 files changed, 3 insertions(+), 2 deletions(-) >>> >>> diff --git a/libavcodec/libvorbis.c b/libavcodec/libvorbis.c >>> index 991c64f..a084a46 100644 >>> --- a/libavcodec/libvorbis.c >>> +++ b/libavcodec/libvorbis.c >>> @@ -267,12 +267,13 @@ static int oggvorbis_encode_frame(AVCodecContext >>> *avctx, unsigned char *packets, >>> return vorbis_error_to_averror(ret); >>> } >>> } else { >>> - if (!s->eof) >>> + if (!s->eof) { >>> if ((ret = vorbis_analysis_wrote(&s->vd, 0)) < 0) { >>> av_log(avctx, AV_LOG_ERROR, "error in >>> vorbis_analysis_wrote()\n"); >>> return vorbis_error_to_averror(ret); >>> } >>> - s->eof = 1; >>> + s->eof = 1; >>> + } >> >> Does this make any practical difference? > > well, we do flush more than once, so it does make a difference. not a > practical one though... it just seemed cleaner to me this way.
I don't really care either way. Speed is irrelevant on that code path. -- Måns Rullgård [email protected] _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
