Luca Barbato <[email protected]> writes:

> On 28/03/12 06:57, Diego Biurrun wrote:
>> On Wed, Mar 28, 2012 at 02:50:57PM +0100, Måns Rullgård wrote:
>>> Diego Biurrun <[email protected]> writes:
>>>
>>>> dvdec.c uses nothing from dv_tablegen.h.  As a welcome side-effect, this
>>>> fixes compilation of that file with hardcoded tables enabled.
>>>
>>> I don't see it failing...
>> 
>> Me neither at first, but I could reproduce it with
>> 
>> configure --enable-gpl --enable-hardcoded-tables
>> make
>> make clean
>> make libavcodec/dvdec.o
>> 
>> in the end.  In any case that #include does not belong there, even if
>> a deeper problem should be lurking somewhere.
>
> Basically a chicken egg issue since you can't build the dependency file
> using -MMD if an header is missing, thus we'd have to use a separate
> rule with -MG to avoid that I'm afraid.

All we have to do is apply the patch.  The file that actually needs the
tables already has the required dependencies listed in the makefile.

-- 
Måns Rullgård
[email protected]
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to