IMO slightly better: configure: fall back on checking for SDL_Init() if primary SDL check fails
On Wed, Mar 28, 2012 at 08:46:59PM +0300, Martin Storsjö wrote: > SDL 1.3 (which is the current version available e.g. in > macports) doesn't contain SDL_Linked_Version. > > The current check for SDL_Linked_Version (available since SDL > 1.2.13) was added 8f1b06c8, because including the headers for was added in > SDL_Init redirects the main function, requiring linking the main() > SDLmain library for linking to work. When using the normal > function checks in configure, we don't link to any extra > libraries. nit: If you used lines about 80 characters instead of about 60 characters in length, this log message would be shorter. > --- a/configure > +++ b/configure > @@ -2983,7 +2983,8 @@ if enabled libdc1394; then > > -if check_pkg_config sdl SDL_version.h SDL_Linked_Version; then > +if check_pkg_config sdl SDL_version.h SDL_Linked_Version || > + check_pkg_config sdl SDL.h SDL_Init; then > check_cpp_condition SDL.h "(SDL_MAJOR_VERSION<<16 | SDL_MINOR_VERSION<<8 > | SDL_PATCHLEVEL) >= 0x010201" $sdl_cflags && > enable sdl && > check_struct SDL.h SDL_VideoInfo current_w $sdl_cflags && enable > sdl_video_size Patch OK, preferably with my suggestions for the log message. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
