Hi, On Mon, Apr 2, 2012 at 12:44 PM, Diego Biurrun <[email protected]> wrote: > On Mon, Apr 02, 2012 at 10:13:50AM -0700, Ronald S. Bultje wrote: >> >> On Sun, Apr 1, 2012 at 4:55 AM, Diego Biurrun <[email protected]> wrote: >> > - for (j = 0; j < filterSize; j++) { >> > + for (j = 0; j < filterSize; j++) >> > val += src[srcPos + j] * filter[filterSize * i + j]; >> > - } >> >> I've seen you do this in a few places now, I really don't know if it's >> a good idea to remove these brackets unconditionally... This isn't >> K&R, this is third/first person bikesheddery. I want blue. > > This is K&R. > >> > - for (j = 0; j < filterSize; j++) { >> > + for (j = 0; j < filterSize; j++) >> > val += src[srcPos + j] * filter[filterSize * i + j]; >> > - } >> >> Blue. > > Kernighan-color > >> > - for (j=0; j<filterSize; j++) { >> > - val += ((int)src[srcPos + j])*filter[filterSize*i + j]; >> > - } >> > + for (j = 0; j < filterSize; j++) >> > + val += ((int)src[srcPos + j]) * filter[filterSize * i + j]; >> >> Blue. > > Ritchie-color > >> > - for (j=0; j<filterSize; j++) { >> > - val += ((int)src[srcPos + j])*filter[filterSize*i + j]; >> > - } >> > + for (j = 0; j < filterSize; j++) >> > + val += ((int)src[srcPos + j]) * filter[filterSize * i + j]; >> >> Blue. > > Kernighan-Ritchie-color
I don't like it. >> > + const int vChrBufSize = c->vChrBufSize; >> > + uint8_t *formatConvBuffer = c->formatConvBuffer; >> > + const int chrSrcSliceY = srcSliceY >> c->chrSrcVSubSample; >> > + const int chrSrcSliceH = -((-srcSliceH) >> c->chrSrcVSubSample); >> >> ? >> >> > + yuv2packed2_fn yuv2packed2 = c->yuv2packed2; >> > + yuv2packedX_fn yuv2packedX = c->yuv2packedX; >> > int should_dither = is9_OR_10BPS(c->srcFormat) || >> > is16BPS(c->srcFormat); >> >> ? > > I don't understand. The vertical alignment of the '=' is off for the lines indicates. Ronald _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
