Hi, On Mon, Apr 2, 2012 at 4:20 PM, Diego Biurrun <[email protected]> wrote: > On Mon, Apr 02, 2012 at 06:52:38PM -0400, Derek Buitenhuis wrote: >> >> --- a/libswscale/swscale_internal.h >> +++ b/libswscale/swscale_internal.h >> @@ -627,6 +627,14 @@ const char *sws_format_name(enum PixelFormat format); >> (av_pix_fmt_descriptors[x].nb_components >= 2 && \ >> (av_pix_fmt_descriptors[x].flags & PIX_FMT_PLANAR)) >> >> +#define isPackedRGB(x) \ >> + ((av_pix_fmt_descriptors[x].flags & \ >> + (PIX_FMT_PLANAR | PIX_FMT_RGB)) == PIX_FMT_RGB) >> + >> +#define isPlanarRGB(x) \ >> + ((av_pix_fmt_descriptors[x].flags & \ >> + (PIX_FMT_PLANAR | PIX_FMT_RGB)) == (PIX_FMT_PLANAR | PIX_FMT_RGB)) > > This is now one of the pretty files, so I'll insist: Align the \ on > column 64, like the macros above. > >> + switch (c->dstFormat) { >> + case PIX_FMT_BGR24: >> + gbr24ptopacked24((const uint8_t* []) {src[1], src[0], src[2]}, > > uint8_t *[], more below > > Don't bother sending a fresh patch for these though, just change locally > and wait for further comments.
No further comments from me (LGTM). Ronald _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
