"Ronald S. Bultje" <[email protected]> writes: > Hi, > > On Apr 4, 2012 7:43 AM, "Måns Rullgård" <[email protected]> wrote: >> >> "Ronald S. Bultje" <[email protected]> writes: >> >> > Hi, >> > >> > On Wed, Apr 4, 2012 at 6:49 AM, Diego Biurrun <[email protected]> wrote: >> >> --- >> >> libavcodec/h264.c | 2 ++ >> >> libavcodec/h264.h | 1 + >> >> libavcodec/h264_cabac.c | 4 ++-- >> >> libavcodec/h264_cavlc.c | 4 ++-- >> >> 4 files changed, 7 insertions(+), 4 deletions(-) >> > >> > Why not (like all other tables) in h264data.h? >> >> That file is a problem. It defines piles of static data and is included >> in multiple C files, meaning all those tables are duplicated a whopping >> 8 times. Let's not make it even worse. > > I agree, but creating various places where tables are defined is obviously > not a solution. How about we create h264data.c and really fix this?
Go for it. -- Måns Rullgård [email protected] _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
