Hi, On Wed, Apr 4, 2012 at 8:16 AM, Christophe Gisquet <[email protected]> wrote: > 2012/4/4 Ronald S. Bultje <[email protected]>: >>> +pw_rnd7: times 8 dw 1 << (16 - 8) >> >> (You can just call this pw_256 if you want.) > > As the symbol does not exist elsewhere, I thought this would be more > meaningful as to its use (there's an equivalent usage in rv40dsp), at > least compared to the name pw_256.
Yeah, I'm just wondering if it makes sense to describe the data, not its use, since the same data could be used for multiple things. Anyway, this is extremely minor, let's ignore it for now. Rest of the patch is obviously OK. I just had this amazing idea of converting all these pw_... tables in dsputil_mmx.c to yasm. So pretty. But so much effort... Ronald _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
