On 04/04/2012 09:07 AM, Christophe Gisquet wrote: > Hi, > > some variables are declared as signed. For some of them at least, this > leads to less optimal code. More careful analysis would be needed, > although the ones in this patch mattered the most. > > Christophe > > > 0004-ape-Use-unsigned-integer-maths.patch > > > From 3b3bf9e53cfeebcec2b838eb4ff8d28f62ad84c2 Mon Sep 17 00:00:00 2001 > From: Christophe Gisquet <[email protected]> > Date: Tue, 28 Feb 2012 17:42:12 +0100 > Subject: [PATCH 4/4] ape: Use unsigned integer maths > > This involves a division that should be a shift. > --- > libavcodec/apedec.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/apedec.c b/libavcodec/apedec.c > index a9953e1..b4a0d73 100644 > --- a/libavcodec/apedec.c > +++ b/libavcodec/apedec.c > @@ -393,7 +393,7 @@ static inline int range_get_symbol(APEContext *ctx, > } > /** @} */ // group rangecoder > > -static inline void update_rice(APERice *rice, int x) > +static inline void update_rice(APERice *rice, unsigned int x) > { > int lim = rice->k ? (1 << (rice->k + 4)) : 0; > rice->ksum += ((x + 1) / 2) - ((rice->ksum + 16) >> 5); > @@ -406,7 +406,7 @@ static inline void update_rice(APERice *rice, int x) > > static inline int ape_decode_value(APEContext *ctx, APERice *rice) > { > - int x, overflow; > + unsigned int x, overflow; > > if (ctx->fileversion < 3990) { > int tmpk; > -- 1.7.8.msysgit.0
Looks correct to me. -Justin _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
