On Wed, May 09, 2012 at 09:13:23AM +0200, Anton Khirnov wrote: > > --- a/libavutil/samplefmt.h > +++ b/libavutil/samplefmt.h > @@ -209,4 +209,17 @@ int av_samples_copy(uint8_t **dst, uint8_t **src, int > dst_offset, int src_offset > > +/** > + * Fill an audio buffer with a constant value. > + * > + * @param audio_data array of pointers to data planes > + * @param byte to fill the data with > + * @param offset offset in samples at which to start filling > + * @param nb_samples number of samples to fill > + * @param nb_channels number of audio channels > + * @param sample_fmt audio sample format > + */ > +int av_samples_set(uint8_t **audio_data, int b, int offset, int nb_samples, > + int nb_channels, enum AVSampleFormat sample_fmt);
"b" is missing from the parameters list and vertically aligning the parameter descriptions would make this more readable. It would also likely have caught this mistake. Renaming "b" to "byte" also sounds like a good idea to me. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
