On Sun, Jun 03, 2012 at 11:43:23PM +0200, Anton Khirnov wrote:
> 
> On Sun, 03 Jun 2012 17:53:22 +0200, Diego Biurrun <[email protected]> wrote:
> > They are not really header files, so treating them as templates is more
> > consistent.  This also fixes generation of Doxygen documentation, which
> > got confused by #including files within function declarations.
> 
> side note: I'd really appreciate it if you could integrate doxy
> generation into the build system

Planned, let's see if I can find some time soon.

> so only doxy for the installed headers is generated.

I don't think that is a good idea.  While much of our doxy should not
really be doxy, restricting doxy generation to installed headers is
not the right solution.

> > ---
> >  doc/Makefile                                       |    2 +-
> >  doc/print_options.c                                |    4 ++--
> >  libavcodec/options.c                               |    2 +-
> >  .../{options_table.h => options_table_template.c}  |   11 -----------
> 
> The _template part is pointless. Make it just options_table.c

Changed locally.

> Otherwise LGTM.

I'll wait a bit more for further opinions before pushing.

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to