On 06/09/2012 01:37 PM, John Stebbins wrote: > Howdy, > > I expect this will get some red ink on it. But here's a patch that adds > dolby and dolby pro logic ii downmix support to libavresample. > I am in the process of updating the version of libav that is used by > HandBrake and this is the only missing feature of libavresample that > prevents us from dropping our internal downmix code and switching to > libavresample. > > I've tested it on a dplii capable receiver and I get the expected results.
Looks pretty good! The implementation looks right. I would use AV_STEREO_DOWNMIX_UNSPECIFIED or AV_STEREO_DOWNMIX_DEFAULT instead of AV_STEREO_DOWNMIX_NONE. The libavresample API is not declared stable yet, so you can just change the function instead of adding a new one. Expecting this change was actually one of the main reasons for keeping the API unstable. We also need more pieces in place to be able to make this work in the af_resample filter, and also to export the preferred downmix mode from the decoder (if we even want to do that...). Thanks! Justin _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
