On Mon, 11 Jun 2012 10:51:28 +0200, Diego Biurrun <[email protected]> wrote:
> On Fri, Jun 08, 2012 at 03:49:56PM -0400, Justin Ruggles wrote:
> > Needed to properly export avpriv_* symbols.
> > 
> > --- a/libavutil/libavutil.v
> > +++ b/libavutil/libavutil.v
> > @@ -1,4 +1,4 @@
> >  LIBAVUTIL_$MAJOR {
> > -        global: av_*; ff_*; avutil_*;
> > +        global: av*; ff_*;
> >          local: *;
> 
> Shouldn't we be a bit more explicit here and export both "av_*" and
> "avpriv_*" instead?  If somebody adds "avoid_failure()" or the
> "avert_doomsday()" function that everybody is waiting for, then
> the greedy implicit pattern will cover those functions.
> 

That somebody should be stabbed with a rusty spork.
All non-static functions should have a ff_ prefix (those are now
exported as well, but that's an unrelated problem)

-- 
Anton Khirnov
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to