"Ronald S. Bultje" <[email protected]> writes: > Hi, > > On Jun 11, 2012 10:44 AM, "Måns Rullgård" <[email protected]> wrote: >> >> "Ronald S. Bultje" <[email protected]> writes: >> >> > Hi, >> > >> > On Jun 11, 2012 9:36 AM, "Anton Khirnov" <[email protected]> wrote: >> >> >> >> Our w32pthreads wrapper has various issues and is only supposed to be >> >> used in libavcodec. >> > >> > Can you elaborate on the issue? It is supposed to work. >> >> w32pthreads.h contains piles of static definitions, both code and data. >> #including it in multiple places is at best wasteful, probably harmful >> in some subtle way. It also happens to not compile as is. > > So fix it! Since when do we allow hacks like disable threads on win32
It's only disabling the rather special case of reading multiple input files in different threads. Normal multi-threaded decoding is not affected. > because someone is too lazy to really write minimal code? > > Patch is not OK, at best a very short-term stopgap while someone works on a > real solution. Since the code currently doesn't compile for Windows, I think the patch is acceptable in that it fixes that breakage. If someone feels motivated to fix it properly, that would of course be welcome. Personally I have neither the knowledge nor the motivation to work on that. -- Måns Rullgård [email protected] _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
