On 06/11/2012 04:53 PM, Ronald S. Bultje wrote: > Hi, > > On Jun 11, 2012 10:44 AM, "Måns Rullgård" <[email protected]> wrote: >> w32pthreads.h contains piles of static definitions, both code and data. >> #including it in multiple places is at best wasteful, probably harmful >> in some subtle way. It also happens to not compile as is. > > So fix it! Since when do we allow hacks like disable threads on win32 > because someone is too lazy to really write minimal code? > > Patch is not OK, at best a very short-term stopgap while someone works on a > real solution.
The current solutions are: a - fix our sort of restricted and limited win32 support to cover also this use-case. b - brutally import winpthreads from mingw64, commit the sin of bundling foreign code and be damned to sync whenever is needed. c - do not enable a fringe feature useful in a handful of cases, all targeting servers [a] requires expertise and time few among us have [b] requires just an agreement about that and some testing to make sure it works. [c] the patch proposed. I dislike [b] can't do [a] and I'd accept [c]. lu -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
