Kostya Shishkov <[email protected]> writes:

>> diff --git a/libavcodec/snow.c b/libavcodec/snow.c
>> index 384cda8..edd7d07 100644
>> --- a/libavcodec/snow.c
>> +++ b/libavcodec/snow.c
>> @@ -440,6 +440,8 @@ av_cold int ff_snow_common_init(AVCodecContext *avctx){
>>  
>>      s->spatial_idwt_buffer= av_mallocz(width*height*sizeof(IDWTELEM));
>>      s->spatial_dwt_buffer= av_mallocz(width*height*sizeof(DWTELEM)); 
>> //FIXME this does not belong here
>> +    s->temp_dwt_buffer = av_mallocz(width * sizeof(DWTELEM));
>> +    s->temp_idwt_buffer = av_mallocz(width * sizeof(IDWTELEM));
>
> Uhm, are any of these checked?

Doesn't look like it.  Are you surprised?

> The patch looks OK though.

I hate adding unchecked mallocs, even next to existing ones.

-- 
Måns Rullgård
[email protected]
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to