On Sat, 16 Jun 2012, Samuel Pitoiset wrote:
On Sat, Jun 16, 2012 at 12:29 PM, Jordi Ortiz <[email protected]> wrote:--- libavformat/tcp.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)diff --git a/libavformat/tcp.c b/libavformat/tcp.c index a6eeeb0..7e348f7 100644 --- a/libavformat/tcp.c +++ b/libavformat/tcp.c @@ -90,7 +90,11 @@ static int tcp_open(URLContext *h, const char *uri, int flags) ret = ff_neterrno(); goto fail1; } - listen(fd, 1); + ret = listen(fd, 1); + if (ret) { + ret = ff_neterrno(); + goto fail1; + }I think listen() should return -1 in case of failure...
Yes, listen returns 0 on success and -1 on failure. If ret == 0, it will not hit the error case, but ret == -1 will trigger "if (ret)". The bind() call above has the same semantics and the same kind of error checking.
// Martin
_______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
