On Sun, 17 Jun 2012, Justin Ruggles wrote:
On 06/17/2012 03:47 PM, Martin Storsjö wrote:
On Sun, 17 Jun 2012, Justin Ruggles wrote:
[A bunch of comments trimmed]
Updated locally
On 06/17/2012 11:03 AM, Martin Storsjö wrote:
+
+ WebRtcIlbcfix_DecodeImpl((WebRtc_Word16*) s->frame.data[0],
(const WebRtc_UWord16*) buf, &s->decoder, 1);
+
break the long line.
can this return an error?
Nope, it returns void.
ok.
+
+ if ((mode = get_mode(avctx)) < 0)
+ return AVERROR(EINVAL);
Having a private option to set 20ms or 30ms mode could be useful rather
than having to know the corresponding bitrate.
That's also possible, although in this case, you don't need to know them
exactly, anything below 14 kbps gets the 13.333 kbps mode, anything
above gets the 15.200 one. (This is about the same as we do for AMR-NB,
where we pick the mode that is the closest match.)
If we have an option, it would need to have a "auto"/0 mode as default,
which picks it from the bitrate, otherwise one can't set it via the
bitrate at all. If you still want the option, I can add it.
Yes, that sounds fine. One way to do this would be to set the bit_rate
default to 0, then only use the mode option if the user does not set
bit_rate explicitly. That way you don't need an "auto" mode, you just
have a default mode for use when bit_rate is not specified.
Ok, I'll give it a shot tomorrow.
// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
