On 06/18/2012 10:40 AM, Martin Storsjö wrote:
> +    case CODEC_ID_ILBC:
> +        if (!st->codec->block_align) {
> +            av_log(s1, AV_LOG_ERROR, "No iLBC block size specified\n");
> +            goto fail;
> +        }

who's setting this value? shall we check it is one of the two supported
one? Can we have a fallback instead of an error?

> +        case CODEC_ID_ILBC:
> +            av_strlcatf(buff, size, "a=rtpmap:%d iLBC/%d\r\n"
> +                                    "a=fmtp:%d mode=%d\r\n",
> +                                     payload_type, c->sample_rate,
> +                                     payload_type, c->block_align == 38 ? 20 
> : 30);
> +            break;

I guess we should be stricter in the check before.

lu

-- 

Luca Barbato
Gentoo/linux
http://dev.gentoo.org/~lu_zero

_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to