"Ronald S. Bultje" <[email protected]> writes: > From: "Ronald S. Bultje" <[email protected]> > > --- > libavcodec/snowenc.c | 42 ++++++++++++++++++++++-------------------- > 1 file changed, 22 insertions(+), 20 deletions(-) > > diff --git a/libavcodec/snowenc.c b/libavcodec/snowenc.c > index 7b010e1..ac276f9 100644 > --- a/libavcodec/snowenc.c > +++ b/libavcodec/snowenc.c > @@ -662,7 +662,7 @@ static inline int get_block_bits(SnowContext *s, int x, > int y, int w){ > } > } > > -static int get_block_rd(SnowContext *s, int mb_x, int mb_y, int plane_index, > const uint8_t *obmc_edged){ > +static int get_block_rd(SnowContext *s, int mb_x, int mb_y, int plane_index, > uint8_t (* const obmc_edged)[MB_SIZE * 2]){
That const doesn't do what you probably think it does. This declares the pointer as const, not what it points to. Same comment applies elsewhere as well. [...] > const int b_w= (MB_SIZE >> s->block_max_depth); > - uint8_t obmc_edged[b_w*2][b_w*2]; > + uint8_t obmc_edged[MB_SIZE * 2][MB_SIZE * 2]; > > + assert(b_w <= MB_SIZE); The assert is rather pointless considering how b_w is calculated. Rest of patch looks OK. -- Måns Rullgård [email protected] _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
