Janne Grunau <[email protected]> writes:
> On 2012-06-18 14:37:02 +0100, Måns Rullgård wrote:
>> From: "Ronald S. Bultje" <[email protected]>
>>
>> ---
>> configure | 4 +++-
>> libavutil/mem.c | 6 ++++++
>> 2 files changed, 9 insertions(+), 1 deletion(-)
>>
>> diff --git a/configure b/configure
>> index a5d2787..f1f58a7 100755
>> --- a/configure
>> +++ b/configure
>> @@ -1049,6 +1049,7 @@ HAVE_LIST="
>> $ARCH_EXT_LIST
>> $HAVE_LIST_PUB
>> $THREADS_LIST
>> + aligned_malloc
>> aligned_stack
>> alsa_asoundlib_h
>> altivec_h
>> @@ -2834,6 +2835,7 @@ check_func ${malloc_prefix}memalign &&
>> enable memalign
>> check_func mkstemp
>> check_func mmap
>> check_func ${malloc_prefix}posix_memalign && enable posix_memalign
>> +check_func ${malloc_prefix}_aligned_malloc && enable aligned_malloc
>> check_func setrlimit
>> check_func strerror_r
>> check_func strptime
>
> we could set malloc_prefix to _aligned_ for msvc. It avoids unfortunately
> only the #ifdef for free. malloc and realloc still needs the ifdef due to
> the extra argument. Not really clearer, both ways are ok.
>
> Configure check is inconsistent with the code, either loose the
> ${malloc_prefix} from the configure check or add the defines for
> MALLOC_PREFIX_aligned_* in mem.c
I was going to suggest dropping the ${malloc_prefix} here. This feature
exists so the standard allocator can be replaced by a custom one, and
there's no reason why a custom allocator can't use the standard
interface.
--
Måns Rullgård
[email protected]
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
