On Fri, 29 Jun 2012, Luca Barbato wrote:
On 06/29/2012 10:47 AM, Martin Storsjö wrote:
I guess this looks mostly sensible, once the cosmetics parts are
removed. This almost adds support for multiple streams, as long as all
of them use separate codecs, right?
That is a side effect, support for multiple stream could be added if we
want to fix our rtmp and make the flv decoder and encoder aware of
streams id different than 0, but that is another issue.
This changes the fact that the read_header function used to set up
streams for audio/video - now that this isn't done,
avformat_find_stream_info() might perhaps return too soon before all
streams have been seen, or do we process "enough" data for that anyway?
I could try to fix that by completely setup the streams (so the codec
match), is the patch interesting though?
The patch looks mostly sane so it might be worthwhile (especially if
you're going to add support for multiple streams later).
I also forgot to mention, you seem to duplicate a lot of code for mapping
the flv packet fields to codec ids, it might be better to factorize that
in some way, if possible...
// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
