Kostya Shishkov <[email protected]> writes:

> On Mon, Jul 02, 2012 at 11:23:16AM +0100, Måns Rullgård wrote:
>> Martin Storsjö <[email protected]> writes:
>> 
>> > From: "Ronald S. Bultje" <[email protected]>
>> >
>> > ---
>> >  libavcodec/snow.c    |    4 ++++
>> >  libavcodec/snow.h    |    1 +
>> >  libavcodec/snowenc.c |    2 +-
>> >  3 files changed, 6 insertions(+), 1 deletion(-)
>> 
>> Someone really ought to fix emulated_edge_mc() to take separate strides
>> for source and destination.  It would save everyone allocating
>> full-width buffers only to use a single block.
>
> Well, after that it's used in motion compensation functions that
> expect source stride to be equal to destination stride.

Feel free to fix that too.  FWIW, the VP8 MC functions have separate
strides.

I'm not blocking the patch, just pointing out how insane the code is.

-- 
Måns Rullgård
[email protected]
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to