Diego Biurrun <[email protected]> writes: > On Mon, Jul 02, 2012 at 10:19:36PM +0200, Janne Grunau wrote: >> On 2012-07-02 22:10:16 +0200, Diego Biurrun wrote: >> > We have version.h files in subdirectories, which can clash if both headers >> > need to be #included in the same file. >> >> There is now need to include the version.h files from the >> subdirectories. They should be considered private and are >> included throught av*.h. There are merely an extension of >> those files. > > The rule is that files explicitly #include what they need. > We don't have such "private" headers that are not meant to > be #included directly.
Actually, we do. libavutil/internal.h is one of them. Regarding this patch, to maintain API compatibility, the libavfoo/avfoo.h files have to include the new version.h files, at least until the next API bump. Since we're making this promise to others, we can rely on it ourselves as well, at least as far as adding those #include lines in a separate patch. -- Måns Rullgård [email protected] _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
