On Wed, Jul 04, 2012 at 01:00:10AM +0100, Måns Rullgård wrote: > Diego Biurrun <[email protected]> writes: > > On Mon, Jul 02, 2012 at 06:36:22PM +0100, Måns Rullgård wrote: > >> Diego Biurrun <[email protected]> writes: > >> > On Mon, Jul 02, 2012 at 04:10:20PM +0100, Mans Rullgard wrote: > >> >> --- /dev/null > >> >> +++ b/tests/fate/flac.mak > >> >> @@ -0,0 +1,19 @@ > >> >> +FATE_FLAC += fate-flac-chmode-indep > >> >> \ > >> >> + fate-flac-chmode-left-side > >> >> \ > >> >> + fate-flac-chmode-mid-side > >> >> \ > >> >> + fate-flac-chmode-right-side > >> >> \ > >> >> + fate-flac-fixed > >> >> \ > >> >> + fate-flac-lpc-cholesky > >> >> \ > >> >> + fate-flac-lpc-levinson > >> >> \ > >> >> + > >> >> +fate-flac-fixed: OPTS = -lpc_type fixed > >> >> +fate-flac-lpc-%: OPTS = -lpc_type $(@:fate-flac-lpc-%=%) > >> >> +fate-flac-chmode-%: OPTS = -ch_mode $(subst -,_, > >> >> $(@:fate-flac-chmode-%=%)) > >> > > >> > Reorder these please. > >> > > >> > More importantly, the need for the subst call seems annoying. You could > >> > rename the tests instead or change the code to accept both '_' and '-'. > >> > >> As I recall, you complained about underscores, wanting hyphens instead, > >> not long ago. Make up your mind. > > > > Actually you had the preference for hyphens. > > No, it was you, and here's the proof: http://patches.libav.org/patch/21665/
You were the one that trolled me into creating that patch. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
