Hi, On Tue, Jul 3, 2012 at 9:11 PM, Ronald S. Bultje <[email protected]> wrote: > +#if ARCH_X86_64 || HAVE_ALIGNED_STACK
The ARCH_X86_64 here is not because that one has aligned stack (it does on win64 also; see e.g. [1]). Aligned or unaligned stack on win64 (or any 64bit platform for that matter) is an implementation detail that should indeed be hidden under HAVE_ALIGNED_STACK. After all, there may exist other 64bit platforms where the stack is not 16-byte aligned. However, the functions #if'ed here don't use stack _at all_ on 64bit (instead, they use xmm8-15, which don't exist on 32bit platforms), thus stack alignment or lack thereof is irrelevant. Therefore, I think including ARCH_X86_64 in the definition here is more clear. If others disagree, feel free to remove that part and commit as such. Ronald [1] http://www.godevtool.com/GoasmHelp/64bits.htm#alignsta _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
