On Wed, 4 Jul 2012, Samuel Pitoiset wrote:
On Wed, Jul 4, 2012 at 3:15 PM, Måns Rullgård <[email protected]> wrote:
Samuel Pitoiset <[email protected]> writes:
[...]
+void av_xtea_crypt(AVXTEA *ctx, uint8_t *dst, const uint8_t *src, int count,
+ uint8_t *iv, int decrypt)
+{
+ int i;
+
+ while (count > 0) {
[...]
+ count -= 8;
+ }
+}
[...]
+/**
+ * Encrypt or decrypt a buffer using a previously initialized context.
+ *
+ * @param x an AVXTEA context
+ * @param dst destination array, can be equal to src
+ * @param src source array, can be equal to dst
+ * @param count number of 8 byte blocks
The description of the count argument is wrong.
Why this description is wrong?
If I pass the parameter count = 2, to indicate that there's two 8-byte
blocks, it will only process the first one with the current code. Since
the implementation and the description don't match, I'd rather have you
fix the implementation (since the description matches the docs and
behaviour of AES).
// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
