On Thu, Jul 05, 2012 at 01:09:08PM +0200, Samuel Pitoiset wrote: > On Tue, Jul 3, 2012 at 10:47 AM, Martin Storsjö <[email protected]> wrote: > > On Thu, 28 Jun 2012, Samuel Pitoiset wrote: > >> --- /dev/null > >> +++ b/libavformat/rtmpenc.c > >> @@ -0,0 +1,539 @@ > >> +/* > >> + * RTMPE network protocol > >> + * Copyright (c) 2012 Samuel Pitoiset > >> + * > >> + * This file is part of Libav. > >> + * > >> + * Libav is free software; you can redistribute it and/or > >> + * modify it under the terms of the GNU Lesser General Public > >> + * License as published by the Free Software Foundation; either > >> + * version 2.1 of the License, or (at your option) any later version. > >> + * > >> + * Libav is distributed in the hope that it will be useful, > >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of > >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > >> + * Lesser General Public License for more details. > >> + * > >> + * You should have received a copy of the GNU Lesser General Public > >> + * License along with Libav; if not, write to the Free Software > >> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA > >> 02110-1301 USA > >> + */ > > > > This file contains large sections that are copied from librtmp, you really > > must mention that in the copyright header then. Transcribing code (reading, > > understanding what it does, writing new code doing the same, fitting our > > API) is one thing, but in this case some functions even are byte-by-byte > > identical to the corresponding ones in librtmp, including the comments. > > > > Not sure how much this is an issue any longer since you've reworked the > > blowfish code since then, but I just thought I should point it out. > > Now, the code is not byte-to-byte identical, so in my opinion, it's > not needed to mention that in the copyright header.
However, byte-for-byte copying is not what defines a copyright violation. Imagine somebody taking the play "Romeo and Juliet", replacing the male protagonists name with "Rodeo". Surely not a byte-for-byte copy, but surely a copyright violation. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
