"Ronald S. Bultje" <[email protected]> wrote:
>Hi, > >On Sat, Jul 7, 2012 at 11:03 AM, Anton Khirnov <[email protected]> >wrote: >> - while ((c = getopt(argc, argv, "hi:o:")) != -1) { >> - switch (c) { >> - case 'h': >> + while (optindex < argc) { >> + char *opt = argv[optindex++]; >> + >> + if (!opt[0]) { > >Can that trigger? I don't think this ever will, will it? Of course it can. A program argument can be an empty string. >> case 'o': >> - outfilename = optarg; >> + outfilename = argv[optindex++]; >> break; > >Forbidding spaces in fft-test and requiring it here seems ... >inconsistent. Let's choose one policy and use it in both places. Make it optional everywhere. -- Måns Rullgård _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
